VarAssNode pushType() -> VarStdAss pop type and VarDec pop type (if has ass) #98

New Issue

deavmi · 2023-01-29T14:09:13Z

deavmi commented

2023-01-29 14:09:13 +00:00

What is this?

A variable assigment node pushes its type then one of the two consumes it:

Standalone variable assignment node
Varaiable declaration (with an assignment enabled) node

Just a reminder this was added to the above 2 (popping code/popType()):

// TODO: A popType() should be done here techncially, IF we do this then it
// ... must be pushed by VariableAssigmnetNode
Type assignmentType = popType();
assert(assignmentType);

And for the variable assignment node (pushing code/addType()):

// NOTE: DIscussion about puysuhing VariableAsignmentNode and poppiung later in varStdAssAlone and VarDecNode
addType(variableType);

### What is this? A variable assigment node pushes its type then one of the two consumes it: 1. Standalone variable assignment node 2. Varaiable declaration (with an assignment enabled) node Just a reminder this was added to the above 2 (popping code/`popType()`): ```d // TODO: A popType() should be done here techncially, IF we do this then it // ... must be pushed by VariableAssigmnetNode Type assignmentType = popType(); assert(assignmentType); ``` And for the variable assignment node (pushing code/`addType()`): ```d // NOTE: DIscussion about puysuhing VariableAsignmentNode and poppiung later in varStdAssAlone and VarDecNode addType(variableType); ```

deavmi added reference literal_encodings

2023-01-29 14:09:50 +00:00

deavmi added this to the Dependency tree, type-checking and codegen project 2023-01-29 14:09:54 +00:00

deavmi added the

typing

label 2023-01-29 14:09:59 +00:00

deavmi added this to the Basics milestone 2023-01-29 14:10:01 +00:00

deavmi self-assigned this 2023-01-29 14:10:04 +00:00

deavmi commented

2023-01-29 14:53:26 +00:00