🐞️ Bugfix: Multiple compilations #88

Closed
opened 2023-01-19 19:01:32 +00:00 by deavmi · 6 comments
Owner

What is the issue?

It would seem that when we attempt multiple compilations we get some resolution error. I am under the impression some static fields are not being cleared - that is the only way I can see such a thing happening.

The offending code is below:

string[] testFiles = ["source/tlang/testing/simple_functions.t",
                        "source/tlang/testing/simple_while.t",
                        "source/tlang/testing/simple_for_loops.t",
                        "source/tlang/testing/simple_cast.t",
                        "source/tlang/testing/simple_conditionals.t",
                        "source/tlang/testing/nested_conditionals.t",
                        "source/tlang/testing/simple_discard.t"
                        ];
foreach(string testFile; testFiles)
{
	beginCompilation([testFile]);
}

And the output we get is attached as the image below.

### What is the issue? It would seem that when we attempt multiple compilations we get some resolution error. I am under the impression some `static` fields are not being cleared - that is the only way I can see such a thing happening. The offending code is below: ```d string[] testFiles = ["source/tlang/testing/simple_functions.t", "source/tlang/testing/simple_while.t", "source/tlang/testing/simple_for_loops.t", "source/tlang/testing/simple_cast.t", "source/tlang/testing/simple_conditionals.t", "source/tlang/testing/nested_conditionals.t", "source/tlang/testing/simple_discard.t" ]; foreach(string testFile; testFiles) { beginCompilation([testFile]); } ``` And the output we get is attached as the image below.
deavmi added reference compiler_object 2023-01-19 19:03:33 +00:00
deavmi self-assigned this 2023-01-19 19:03:44 +00:00
deavmi added this to the Basics milestone 2023-01-19 19:03:46 +00:00
deavmi added the
needsfix
qol
labels 2023-01-19 19:03:54 +00:00
deavmi added this to the Compiler project 2023-01-22 13:14:48 +00:00
deavmi started working 2023-07-21 16:39:12 +01:00
Author
Owner

Linked issue #151 as I think that is why it occurss

Linked issue #151 as I think that is why it occurss
deavmi stopped working 2023-07-21 16:39:27 +01:00
15 seconds
deavmi started working 2023-08-21 08:02:09 +01:00
deavmi changed reference from compiler_object to bugfix/fix_multi_compile 2023-08-21 08:03:36 +01:00
deavmi stopped working 2023-08-21 08:10:55 +01:00
8 minutes 46 seconds
deavmi started working 2023-08-21 08:17:54 +01:00
Author
Owner

I am actually drastically increasing code coverage with this now.

I am actually drastically increasing code coverage with this now.
Author
Owner

Almost done....

Almost done....
deavmi changed title from Multiple compilations to 🐞️ Bugfix: Multiple compilations 2023-08-21 08:24:47 +01:00
deavmi stopped working 2023-08-21 08:25:45 +01:00
7 minutes 51 seconds
deavmi added spent time 2023-08-21 08:38:46 +01:00
10 minutes
deavmi started working 2023-08-21 08:38:48 +01:00
Author
Owner

Problem is this module-state ain't lekker, if an exception is thrown we never get to clear that stuff

Problem is this module-state ain't lekker, if an exception is thrown we never get to clear that stuff
Author
Owner

Problem is this module-state ain't lekker, if an exception is thrown we never get to clear that stuff

Could use a scope-guard for now, but honestly it should be part of some sort of DNode state.

> Problem is this module-state ain't lekker, if an exception is thrown we never get to clear that stuff Could use a scope-guard for now, but honestly it should be part of some sort of DNode state.
deavmi stopped working 2023-08-21 08:39:31 +01:00
43 seconds
deavmi added spent time 2023-08-21 11:45:41 +01:00
4 minutes
deavmi started working 2023-08-21 11:45:43 +01:00
deavmi added the due date 2023-08-22 2023-08-21 11:45:58 +01:00
deavmi stopped working 2023-08-21 14:09:07 +01:00
2 hours 23 minutes
deavmi started working 2023-08-27 11:56:00 +01:00
Author
Owner

Merged with CI/CD all passing

Merged with CI/CD all passing ✅
deavmi stopped working 2023-08-27 11:56:19 +01:00
19 seconds
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Total Time Spent: 2 hours 55 minutes
deavmi
2 hours 55 minutes
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

2023-08-22

Reference: tlang/tlang#88
No description provided.