Handling of this (post-iteration statement) #76

New Issue

deavmi · 2023-01-07T11:38:30Z

deavmi commented

2023-01-07 11:38:30 +00:00

WHen we have:

for(int idx = 0; idx < i; idx=idx+1;)

So we call parseStatement() on this, then parseExpression() is called in-turn. It will stop when it sees a ) or ; and then return the expression to parseStatement() - however parseStatement() will expect to have ; and not a ). We could work around this by passing in the requested terminator to parseStatement() and having the default argument value be SymbolType.SEMICOLON.

I think that is a neat fix.

WHen we have: ``` for(int idx = 0; idx < i; idx=idx+1;) ``` So we call `parseStatement()` on this, then `parseExpression()` is called in-turn. It will stop when it sees a `)` or `;` and then return the expression to `parseStatement()` - however `parseStatement()` will expect to have `;` and **not** a `)`. We could work around this by passing in the requested terminator to `parseStatement()` and having the default argument value be `SymbolType.SEMICOLON`. I think that is a neat fix.

deavmi added a new dependency 2023-01-07 11:40:16 +00:00

#75 Implement `parseStatement()`

deavmi commented

2023-01-07 12:04:43 +00:00

Actually, it isn't there me thinks? mmmh:

[WARNING] parseExpression(): Leave
[ERROR] Syntax error: Expected SEMICOLON but got RBRACE, see ) at (7, 40)

Aha! It's in parseAssignment().

As: parseStatement() -> parseName() -> parseAssignment().

We would probably need to parse this thing all the way down.

Actually, it isn't there me thinks? mmmh: ``` [WARNING] parseExpression(): Leave [ERROR] Syntax error: Expected SEMICOLON but got RBRACE, see ) at (7, 40) ``` **Aha!** It's in `parseAssignment()`. As: `parseStatement() -> parseName() -> parseAssignment()`. We would probably need to parse this thing all the way down.

deavmi commented

2023-01-07 13:35:58 +00:00

I have implemented the above and it seems to be working.

deavmi added the due date 2023-01-08

2023-01-07 13:36:09 +00:00

deavmi added reference loops

2023-01-08 10:40:21 +00:00

deavmi added the

parser

label 2023-01-08 10:40:28 +00:00

deavmi self-assigned this 2023-01-08 10:40:31 +00:00

deavmi added this to the Parser project 2023-01-08 10:40:35 +00:00

deavmi added this to the Basics milestone 2023-01-08 10:40:38 +00:00

deavmi commented

2023-01-11 09:28:03 +00:00

We have sorted this out with an update to:

parseStatement()
parseName()
parseAssignment()

They now all take in arguments for a custoim terminator but will default to SymbolType.SEMICOLON.

As of commit ec7d8cf4240b24a2f6fdbd8071195c9efe08d573 on branch loops

We have sorted this out with an update to: 1. `parseStatement()` 2. `parseName()` 3. `parseAssignment()` They now all take in arguments for a custoim terminator but will default to `SymbolType.SEMICOLON`. As of commit `ec7d8cf4240b24a2f6fdbd8071195c9efe08d573` on branch `loops`

deavmi closed this issue

2023-01-11 09:28:03 +00:00

Sign in to join this conversation.

No Label