Revert semantically incorrect VarAssStdAlone context set hack #57

New Issue

deavmi · 2022-12-16T17:23:37Z

deavmi commented

2022-12-16 17:23:37 +00:00

The code:

Variable variable = cast(Variable)tc.getResolver().resolveBest(c, vAsStdAl.getVariableName());
assert(variable);

/* Set the context of the assignment to the Context of the Variable being assigned to */
vAsStdAl.setContext(variable.getContext());

Should rather have this (capture the context coming in from generalPass():

vAsStdAl.setContext(context);

The code: ```d Variable variable = cast(Variable)tc.getResolver().resolveBest(c, vAsStdAl.getVariableName()); assert(variable); /* Set the context of the assignment to the Context of the Variable being assigned to */ vAsStdAl.setContext(variable.getContext()); ``` Should **rather** have this (capture the `context` coming in from `generalPass()`: ```d vAsStdAl.setContext(context); ```

deavmi added reference vardec_varass_dependency

2022-12-16 17:23:44 +00:00

deavmi self-assigned this 2022-12-16 17:23:48 +00:00

deavmi added the

dependency

needsfix

qol

labels 2022-12-16 17:23:57 +00:00

deavmi added this to the Dependency tree, type-checking and codegen project 2022-12-16 17:24:02 +00:00

deavmi added a new dependency 2022-12-16 17:25:27 +00:00

#58 Switch to `generateBest()`

deavmi commented