🐞️ Bugfix: Statement-level FunctionCall have wrong weighting #193

New Issue

deavmi · 2024-05-26T12:59:26+02:00

deavmi commented

2024-05-26 12:59:26 +02:00

Purpose ✍️

If you have the below code and attempt to typecheck/codegen it:

module basic2;

void k(int.int i, int* p)
{
	
}

int main()
{
	int* arr;
	basic2.k(1, arr);

	return 0;
}

Then you get an error saying that arr is trying to be fereneced prior to arr being declared. The only way this is happening is because the function call is re-ordered to appear first and hence the error makes sense then.

Solution ✅

There is no weighting value for the FunctionCall, set it to 2 in the constructor.

Checklist 🗒️

Implemented FunctionCall fix
Added unittests
- Updated Compiler unittests
- Updated Github CI pipelines

## Purpose ✍️ If you have the below code and attempt to typecheck/codegen it: ```d module basic2; void k(int.int i, int* p) { } int main() { int* arr; basic2.k(1, arr); return 0; } ``` Then you get an error saying that `arr` is trying to be fereneced prior to `arr` being declared. The only way this is happening is because the function call is re-ordered to appear first and hence the error makes sense then. ## Solution ✅ There is no weighting value for the `FunctionCall`, set it to 2 in the constructor. ### Checklist 🗒️ - [x] Implemented `FunctionCall` fix - [x] Added unittests - [x] Updated `Compiler` unittests - [x] Updated Github CI pipelines

deavmi added the

needsfix

parser

labels 2024-05-26 12:59:34 +02:00

deavmi started working 2024-05-26 12:59:43 +02:00

deavmi added this to the Basics milestone 2024-05-26 12:59:49 +02:00

deavmi added this to the Parser project 2024-05-26 12:59:52 +02:00

deavmi self-assigned this 2024-05-26 12:59:55 +02:00

deavmi stopped working 2024-05-26 13:00:33 +02:00

50 seconds

deavmi referenced this issue

2024-05-26 13:01:49 +02:00

🧠️ Ideation: dot operator #192

deavmi started working 2024-05-26 13:01:57 +02:00

deavmi changed title from ~~Backport: FunctioNCall standalone werighting~~ to 🐞️ Bugfix: Statement-level FunctionCall have wrong weighting

2024-05-26 13:03:06 +02:00

deavmi added reference bugfix/funccall_stdalone_weighting

2024-05-26 13:03:24 +02:00

deavmi added the due date 2024-05-26

2024-05-26 13:03:32 +02:00

deavmi commented

2024-05-26 13:08:37 +02:00

FunctionCall

Set the weighting to 2 such that when this is used as a standalone statement-level call that is stays in its proper place, and doesn't (for example) jump prior to variable declarations

FunctionCall - Set the weighting to `2` such that when this is used as a standalone statement-level call that is stays in its proper place, and doesn't (for example) jump prior to variable declarations

deavmi commented

2024-05-26 13:09:30 +02:00

Compiler (unittests)