tlang/tlang
tlang
/
tlang
mirror of https://github.com/tbklang/tlang.git
2
0
Fork 0
Code Issues 47 Projects 5 Releases Wiki Activity

⚡ Feature: Aliases support #176

New Issue
Open
opened 2024-05-07 18:21:02 +01:00 by deavmi · 24 comments
deavmi commented 2024-05-07 18:21:02 +01:00
Owner
Copy Link

Purpose ✍️

To add support for declaring aliases and then using them. An alias should be declared and have a right-hand-side expression associated with it. Then the MetaProcessor should do the following:

  1. Discover all declared aliases in a given Module
  2. Perform the replacement of all AliasExpressions with the alias's value

Todo :note

  • Implement
    • Ensure everything is working with it (more MCloneable)
    • Basic
    • Nearest replacement
    • Position-order
      • Don't allow the replacement if the alias is declared AFTER you.
  • Add unittests to actually test it out, cloneability etc.
# Purpose ✍️ To add support for declaring aliases and then using them. An _alias_ should be declared and have a right-hand-side expression associated with it. Then the `MetaProcessor` should do the following: 1. Discover all _declared_ aliases in a given `Module` 2. Perform the replacement of all `AliasExpression`s with the alias's value ## Todo :note - [ ] Implement - [ ] Ensure everything is working with it (more `MCloneable`) - [x] Basic - [x] Nearest replacement - [ ] Position-order * Don't allow the replacement if the alias is declared AFTER you. - [x] Add unittests to actually test it out, cloneability etc.
deavmi started working 2024-05-07 18:21:07 +01:00
deavmi commented 2024-05-07 18:27:51 +01:00
Author
Owner
Copy Link

Working on this now to see what I can get done.

Working on this now to see what I can get done.
deavmi added reference feature/aliases 2024-05-07 18:27:57 +01:00
deavmi added the
parser
meta
 labels 2024-05-07 18:28:03 +01:00
deavmi self-assigned this 2024-05-07 18:28:05 +01:00
deavmi added this to the Parser project 2024-05-07 18:28:12 +01:00
deavmi added this to the Performance and Clarity milestone 2024-05-07 18:28:20 +01:00
deavmi commented 2024-05-07 18:47:49 +01:00
Author
Owner
Copy Link

I now have alias declarations. I now need to work on the MetaProcessor to now firstly look up all VariableExpression(s) and then find those with alias names and replace them with the AliasDeclaration's getExpression() result.

I now have alias _declarations_. I now need to work on the `MetaProcessor` to now firstly look up all `VariableExpression`(s) and then find those with alias names and replace them with the `AliasDeclaration`'s `getExpression()` result.
deavmi commented 2024-05-07 19:38:49 +01:00
Author
Owner
Copy Link

Okay, alias searching is working. Now for the replacement stratergy.

Okay, alias searching is working. Now for the replacement stratergy.
deavmi commented 2024-05-07 19:57:47 +01:00
Author
Owner
Copy Link

It works! 🥓

It works! 🥓
deavmi stopped working 2024-05-07 19:57:50 +01:00
1 hour 36 minutes
deavmi added the due date 2024-05-11 2024-05-07 19:57:56 +01:00
deavmi added spent time 2024-05-07 20:37:11 +01:00
5 minutes
deavmi started working 2024-05-07 20:37:13 +01:00
deavmi commented 2024-05-07 20:37:26 +01:00
Author
Owner
Copy Link

This need to sort out places where MCloneable is not implemented etc.

This need to sort out places where `MCloneable` is not implemented etc.
deavmi stopped working 2024-05-07 20:37:30 +01:00
17 seconds
deavmi added spent time 2024-05-07 20:45:30 +01:00
4 minutes
deavmi started working 2024-05-07 20:45:33 +01:00
deavmi commented 2024-05-07 20:45:40 +01:00
Author
Owner
Copy Link

This need to sort out places where MCloneable is not implemented etc.

Busy with this now...

> This need to sort out places where `MCloneable` is not implemented etc. Busy with this now...
deavmi commented 2024-05-07 20:47:54 +01:00
Author
Owner
Copy Link

This need to sort out places where MCloneable is not implemented etc.

Busy with this now...

Fixed ✅

> > This need to sort out places where `MCloneable` is not implemented etc. > > Busy with this now... Fixed ✅
deavmi commented 2024-05-07 20:48:01 +01:00
Author
Owner
Copy Link

Will push code later tonight

Will push code later tonight
deavmi stopped working 2024-05-07 20:48:10 +01:00
2 minutes 37 seconds
deavmi started working 2024-05-08 08:23:29 +01:00
deavmi commented 2024-05-08 08:33:44 +01:00
Author
Owner
Copy Link

Oh no it brokey actually, with this cnt() example :(

Oh no it brokey actually, with this `cnt()` example :(
deavmi stopped working 2024-05-08 09:02:47 +01:00
39 minutes 18 seconds
deavmi started working 2024-05-08 09:06:05 +01:00
deavmi stopped working 2024-05-08 09:06:19 +01:00
14 seconds
deavmi commented 2024-05-08 09:13:37 +01:00
Author
Owner
Copy Link

It's not replacing for some reason, I feel as though this is some obvious error in the loop but I can't pinpoint it.

It's not replacing for some reason, I feel as though this is some obvious error in the loop but I can't pinpoint it.
deavmi added spent time 2024-05-08 09:28:24 +01:00
30 minutes
deavmi commented 2024-05-08 09:28:33 +01:00
Author
Owner
Copy Link

Looks like not being replaced after all 🤔

Looks like not being replaced after all 🤔
deavmi commented 2024-05-08 09:54:44 +01:00
Author
Owner
Copy Link

image

![image](/attachments/092496d2-5652-465a-abe0-03b8e92fe49a)
image.png
346 KiB
deavmi started working 2024-05-08 11:29:57 +01:00
deavmi added a new dependency 2024-05-08 12:16:53 +01:00
#178 ⚡ Feature: Collector-based resolveUp
deavmi commented 2024-05-08 12:39:45 +01:00
Author
Owner
Copy Link

it is falling through and hitting an MStatementReplaceable of the Expression in VarAss, need to see why that keeps returning true

it is falling through and hitting an `MStatementReplaceable` of the `Expression` in VarAss, need to see why **that** keeps returning `true`
deavmi commented 2024-05-08 12:42:37 +01:00
Author
Owner
Copy Link

Ah it is falling into FunctionCall which is not finished yet, and keeps returning true

Ah it is falling into `FunctionCall` which is not finished yet, and keeps returning `true`
deavmi commented 2024-05-08 12:42:42 +01:00
Author
Owner
Copy Link

GREAT!

GREAT!
deavmi commented 2024-05-08 12:47:30 +01:00
Author
Owner
Copy Link

FunctionCall

  • Made replacement return false for now (ass it is not implemented)
  • Addec MCloneable support
FunctionCall - Made replacement return `false` for now (ass it is not implemented) - Addec `MCloneable` support
deavmi commented 2024-05-08 12:48:35 +01:00
Author
Owner
Copy Link

MetaProcessor

  • Re-worked the alias replacement code
MetaProcessor - Re-worked the alias replacement code
deavmi stopped working 2024-05-08 12:48:40 +01:00
1 hour 18 minutes
deavmi started working 2024-05-08 12:49:21 +01:00
deavmi stopped working 2024-05-08 12:49:42 +01:00
21 seconds
deavmi started working 2024-05-08 12:51:52 +01:00
deavmi stopped working 2024-05-08 12:56:12 +01:00
4 minutes 20 seconds
deavmi started working 2024-05-08 12:56:14 +01:00
deavmi commented 2024-05-08 12:56:29 +01:00
Author
Owner
Copy Link

Added CI/CD tests and also added it to unittests (for code coverage)

Added CI/CD tests and also added it to unittests (for code coverage)
deavmi stopped working 2024-05-08 12:58:21 +01:00
2 minutes 7 seconds
deavmi started working 2024-05-08 16:48:04 +01:00
deavmi commented 2024-05-08 16:56:27 +01:00
Author
Owner
Copy Link

For ordering like this:

alias inner = 1;

int main()
{
	alias inner = 0;
	int i = expr;
	int p = expr;
	int o = inner;
	return i+p+o;
}

We may need to do a first pass to discover all aliases and then sort them. BUT then the context is sort of lacking? Unless we get all parentOf()'s and then distance between containers. Eish!

For ordering like this: ```d alias inner = 1; int main() { alias inner = 0; int i = expr; int p = expr; int o = inner; return i+p+o; } ``` We may need to do a first pass to discover all aliases and then sort them. BUT then the context is sort of lacking? Unless we get all `parentOf()`'s and then distance between containers. Eish!
deavmi commented 2024-05-08 16:58:17 +01:00
Author
Owner
Copy Link

For ordering like this:

alias inner = 1;

int main()
{
	alias inner = 0;
	int i = expr;
	int p = expr;
	int o = inner;
	return i+p+o;
}

We may need to do a first pass to discover all aliases and then sort them. BUT then the context is sort of lacking? Unless we get all parentOf()'s and then distance between containers. Eish!

Maybe, I have an idea. We are actually just doing the search not from the right place. Perhaps, on the place of the VarExp, we should call parentOf() and maybe search from there. So anchor it at the reference point of the alias name, not at the call to doAliasProcess(...)

> For ordering like this: > > ```d > alias inner = 1; > > int main() > { > alias inner = 0; > int i = expr; > int p = expr; > int o = inner; > return i+p+o; > } > ``` > > We may need to do a first pass to discover all aliases and then sort them. BUT then the context is sort of lacking? Unless we get all `parentOf()`'s and then distance between containers. Eish! Maybe, I have an idea. We are actually just doing the search not from the right place. Perhaps, on the place of the `VarExp`, we should call `parentOf()` and maybe search from there. So anchor it at the reference point of the alias name, **not** at the call to `doAliasProcess(...)`
deavmi commented 2024-05-08 17:04:55 +01:00
Author
Owner
Copy Link

For ordering like this:

alias inner = 1;

int main()
{
	alias inner = 0;
	int i = expr;
	int p = expr;
	int o = inner;
	return i+p+o;
}

We may need to do a first pass to discover all aliases and then sort them. BUT then the context is sort of lacking? Unless we get all parentOf()'s and then distance between containers. Eish!

Maybe, I have an idea. We are actually just doing the search not from the right place. Perhaps, on the place of the VarExp, we should call parentOf() and maybe search from there. So anchor it at the reference point of the alias name, not at the call to doAliasProcess(...)

This looks right at least:

[DEBUG] DeclAlis:  [Alias [name: inner, expr: [integerLiteral: 0 (SIGNED_INTEGER)]], Alias [name: expr, expr: 3 cnt()], Alias [name: inner, expr: [integerLiteral: 1 (SIGNED_INTEGER)]]]
> > For ordering like this: > > > > ```d > > alias inner = 1; > > > > int main() > > { > > alias inner = 0; > > int i = expr; > > int p = expr; > > int o = inner; > > return i+p+o; > > } > > ``` > > > > We may need to do a first pass to discover all aliases and then sort them. BUT then the context is sort of lacking? Unless we get all `parentOf()`'s and then distance between containers. Eish! > > Maybe, I have an idea. We are actually just doing the search not from the right place. Perhaps, on the place of the `VarExp`, we should call `parentOf()` and maybe search from there. So anchor it at the reference point of the alias name, **not** at the call to `doAliasProcess(...)` This looks right at least: ``` [DEBUG] DeclAlis: [Alias [name: inner, expr: [integerLiteral: 0 (SIGNED_INTEGER)]], Alias [name: expr, expr: 3 cnt()], Alias [name: inner, expr: [integerLiteral: 1 (SIGNED_INTEGER)]]] ```
deavmi commented 2024-05-08 17:17:00 +01:00
Author
Owner
Copy Link

For ordering like this:

alias inner = 1;

int main()
{
	alias inner = 0;
	int i = expr;
	int p = expr;
	int o = inner;
	return i+p+o;
}

We may need to do a first pass to discover all aliases and then sort them. BUT then the context is sort of lacking? Unless we get all parentOf()'s and then distance between containers. Eish!

Maybe, I have an idea. We are actually just doing the search not from the right place. Perhaps, on the place of the VarExp, we should call parentOf() and maybe search from there. So anchor it at the reference point of the alias name, not at the call to doAliasProcess(...)

This looks right at least:

[DEBUG] DeclAlis:  [Alias [name: inner, expr: [integerLiteral: 0 (SIGNED_INTEGER)]], Alias [name: expr, expr: 3 cnt()], Alias [name: inner, expr: [integerLiteral: 1 (SIGNED_INTEGER)]]]

Found bug, needing to make Program replaceable, did now and looks good

> > > For ordering like this: > > > > > > ```d > > > alias inner = 1; > > > > > > int main() > > > { > > > alias inner = 0; > > > int i = expr; > > > int p = expr; > > > int o = inner; > > > return i+p+o; > > > } > > > ``` > > > > > > We may need to do a first pass to discover all aliases and then sort them. BUT then the context is sort of lacking? Unless we get all `parentOf()`'s and then distance between containers. Eish! > > > > Maybe, I have an idea. We are actually just doing the search not from the right place. Perhaps, on the place of the `VarExp`, we should call `parentOf()` and maybe search from there. So anchor it at the reference point of the alias name, **not** at the call to `doAliasProcess(...)` > > This looks right at least: > > ``` > [DEBUG] DeclAlis: [Alias [name: inner, expr: [integerLiteral: 0 (SIGNED_INTEGER)]], Alias [name: expr, expr: 3 cnt()], Alias [name: inner, expr: [integerLiteral: 1 (SIGNED_INTEGER)]]] > ``` Found bug, needing to make `Program` replaceable, did now and looks good
deavmi commented 2024-05-08 17:48:02 +01:00
Author
Owner
Copy Link

Ey! Stuff is coming together. Just really putting a lot of MCloneables in different places.

Ey! Stuff is coming together. Just really putting a lot of `MCloneable`s in different places.
deavmi stopped working 2024-05-08 18:15:11 +01:00
1 hour 27 minutes
deavmi commented 2024-05-08 18:15:17 +01:00
Author
Owner
Copy Link

Time for a break now

Time for a break now
deavmi started working 2024-05-10 09:16:49 +01:00
deavmi stopped working 2024-05-10 09:21:28 +01:00
4 minutes 39 seconds
Sign in to join this conversation.
feature/aliases
Branches Tags
Clear current reference
master
feature/oop
bugfix/binops_typecheck
feature/do_while_loops
cleanup/container_not_context_container
major/dotting
vardec_varass_dependency
feature/resolver_proxies
bugfix/handle_param_count_arg_mismatch
cleanup/pushback_removal
cleanup/path_trail_deps
cleanup/variable_in_variable_ass
feature/container_update_1
feature/aliases
cleanup/context_drop_container
cleanup/depgen_root_removal
feature/modifiers
bugfix/dgen_expressionless_returns
cleanup/remove_dnodegeneratorbase
feature/comments
feature/operator_precedence
feature/reporting
bugfix/single_line_comment_bug
feature/logging_upgrade
feature/multi_module
feature/unused_vars_detection
feature/container_methods
feature/strat_resolve_collectors
feature/predicate_based_resolver
feature/poolmngr
hotfix/func_defs_in_dep_generator
feature/lexer_improvements
feature/structs
feature/behavec_preinline
bugfix/fix_multi_compile
feature/annotations
hotfix/simply_varexp_dnode_generation
hotfix/jcli_upgrade_fix
feature/class_static_init
feature/universal_coercion
feature/cloneability
hotfix/expect_exception_change
bugfix/recursive_return_statement_check
bugfix/require_return
bugfix/return_type
feature/cleanup1
feature/clean_lexer_interface
research/gmalloc
feature/type_enforcer_cast_instr_emit
feature/meta_programming
feature/direct_func_call
bugfix/return_position
bugfix/is_same_type_fallback
feature/lexer_interface
feature/parser_interface
arrays
pointers
bugfix/function_parameter_type_parse
casting
compiler_object
extern_symbols
literal_encodings
uniform_stdalone_varass
remove_typequeue
linearizer_cleanup
parsetypedev_fix
modules
loops
conditionals
vdva_func_param_merge
function_parameters_fix
path_dependency
function_dep
compiler_levels
parser
constants
constants_float
develop
typecheck
deps_refactor
codegen
lexer
typecheck_refactor_varexp_makeacyclic
weighting
testing_thing
typecheck_refactor_varexp
typecheck_refactor
type_check_codegen_reducedparseclass_excep
typecheck_codegen
typecheck_codegen_educedparseclass
typecheck_reliancetree
static_support
codegen.sync-conflict-20210606-150925-O3W7KWN
develop.sync-conflict-20210606-150924-O3W7KWN
struct_support
typecheck.sync-conflict-20210606-150925-O3W7KWN
entity_declaration_type_checking
symbol_table
parser.sync-conflict-20210405-185821-O3W7KWN
parser_exception_before
develop_before_lexer_parser_merge_parseName
if_statement_parsing
exception_except
expression_parsing
master.sync-conflict-20210316-165421-O3W7KWN
expression_parsing.sync-conflict-20210316-090018-O3W7KWN
Clear current reference
multimodule/changeset2
multimodule/changeset1
pointer_cast_merge
parsetypeddeclaration_onlytype_parsecast_new
pointers_coerce
v0.5.3
v0.5.2
v0.5.1
v0.5.0
v0.4.4
v0.4.3
v0.4.2
v0.4.1
v0.4.0
v0.3.0
v0.2.0
v0.1.0
v0.0.5
v0.0.4
v0.0.3
v0.0.2
v0.0.1
Labels
Clear labels   
dependency

Dependency tree generation

  
emit

Code emitting

  
hashmapper

Anything pertaining to the HashMapper symbol mapping code

  
lebanonmapper

Anything pertaining to the LebanonMapper symbol mapping code

  
lexer

Related to the tokenizer

  
meta

Meta processor related

  
needsfix

Urgent fix required

  
parser

Parser related

  
qol

Quality-of-life related

  
question

A question, not needed fix

  
resolution

Related to the resolver

  
typing

TypeChecker and Resolver related

No Label
dependency
emit
hashmapper
lebanonmapper
lexer
meta
needsfix
parser
qol
question
resolution
typing
Milestone
Clear milestone
No items
No Milestone
Performance and Clarity
Projects
Clear projects
No project
Parser
Assignees
Clear assignees
No Assignees
deavmi
1 Participants
Notifications
Total Time Spent: 5 hours 55 minutes
deavmi
5 hours 55 minutes
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

2024-05-11

Depends on
#178 ⚡ Feature: Collector-based resolveUp
tlang/tlang
Reference: tlang/tlang#176
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?