tlang/tlang
tlang
/
tlang
mirror of https://github.com/tbklang/tlang.git
2
0
Fork 0
Code Issues 47 Projects 5 Releases Wiki Activity

🧹️🧼 Cleanup: Remove root from DNodeGenerator #175

New Issue
Open
opened 2024-05-07 10:37:57 +01:00 by deavmi · 7 comments
deavmi commented 2024-05-07 10:37:57 +01:00
Owner
Copy Link

Purpose ✍️

There is a root variable which is set when we run generalPass(...) on either a Module or Function but it is only actually used when we are calling addFunctionDef to the IFuncDefStore, something of this kind can be derived right there as it is in the Function's module-container resolution stage that sets root in the first place.

## Purpose ✍️ There is a `root` variable which is set when we run `generalPass(...)` on either a `Module` or `Function` **but** it is only actually used when we are calling `addFunctionDef` to the `IFuncDefStore`, something of this kind can be derived right there as it is in the `Function`'s module-container resolution stage that sets `root` in the first place.
deavmi changed title from Remove root from DNodeGenerator to 🧹️🧼 Cleanup: Remove root from DNodeGenerator 2024-05-07 10:38:10 +01:00
deavmi added the
dependency
qol
 labels 2024-05-07 10:38:20 +01:00
deavmi added this to the Clean ups milestone 2024-05-07 10:38:23 +01:00
deavmi self-assigned this 2024-05-07 10:38:27 +01:00
deavmi added this to the Dependency tree, type-checking and codegen project 2024-05-07 10:38:29 +01:00
deavmi started working 2024-05-07 10:38:36 +01:00
deavmi added the due date 2024-05-11 2024-05-07 10:38:39 +01:00
deavmi modified the due date from 2024-05-11 to 2024-05-08 2024-05-07 10:38:45 +01:00
deavmi commented 2024-05-07 10:39:36 +01:00
Author
Owner
Copy Link

DNodeGenerator

  • Removed root
DNodeGenerator - Removed `root`
deavmi commented 2024-05-07 10:41:00 +01:00
Author
Owner
Copy Link

Purpose ✍️

There is a root variable which is set when we run generalPass(...) on either a Module or Function but it is only actually used when we are calling addFunctionDef to the IFuncDefStore, something of this kind can be derived right there as it is in the Function's module-container resolution stage that sets root in the first place.

It gets pooled ONLY for the reason to call .entity on it, so it has nothing to do with dependency nodes per say, just the Module itself of which access to is wanted.

> ## Purpose ✍️ > > There is a `root` variable which is set when we run `generalPass(...)` on either a `Module` or `Function` **but** it is only actually used when we are calling `addFunctionDef` to the `IFuncDefStore`, something of this kind can be derived right there as it is in the `Function`'s module-container resolution stage that sets `root` in the first place. It gets `pooled` **ONLY** for the reason to call `.entity` on it, so it has nothing to do with _dependency nodes_ per say, just the `Module` itself of which access to is wanted.
deavmi commented 2024-05-07 10:42:52 +01:00
Author
Owner
Copy Link

DNodeGenerator

  • When processing a Function (a function definition) discover the Module by which it is contained in on the spot
DNodeGenerator - When processing a `Function` (a function definition) discover the `Module` by which it is contained in on the spot
deavmi commented 2024-05-07 10:43:42 +01:00
Author
Owner
Copy Link

DNodeGenerator

  • Removed all code in generalPass(...) which tried to set the root DNode
DNodeGenerator - Removed all code in `generalPass(...)` which tried to set the `root` DNode
deavmi commented 2024-05-07 10:44:14 +01:00
Author
Owner
Copy Link

Testing now

Testing now
deavmi commented 2024-05-07 10:44:46 +01:00
Author
Owner
Copy Link

Testing now

Works. Now to check the Github.

> Testing now Works. Now to check the Github.
deavmi commented 2024-05-07 10:48:18 +01:00
Author
Owner
Copy Link

CI/CD passes ✅

CI/CD passes ✅
deavmi stopped working 2024-05-07 10:48:22 +01:00
9 minutes 46 seconds
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
feature/oop
bugfix/binops_typecheck
feature/do_while_loops
cleanup/container_not_context_container
major/dotting
vardec_varass_dependency
feature/resolver_proxies
bugfix/handle_param_count_arg_mismatch
cleanup/pushback_removal
cleanup/path_trail_deps
cleanup/variable_in_variable_ass
feature/container_update_1
feature/aliases
cleanup/context_drop_container
cleanup/depgen_root_removal
feature/modifiers
bugfix/dgen_expressionless_returns
cleanup/remove_dnodegeneratorbase
feature/comments
feature/operator_precedence
feature/reporting
bugfix/single_line_comment_bug
feature/logging_upgrade
feature/multi_module
feature/unused_vars_detection
feature/container_methods
feature/strat_resolve_collectors
feature/predicate_based_resolver
feature/poolmngr
hotfix/func_defs_in_dep_generator
feature/lexer_improvements
feature/structs
feature/behavec_preinline
bugfix/fix_multi_compile
feature/annotations
hotfix/simply_varexp_dnode_generation
hotfix/jcli_upgrade_fix
feature/class_static_init
feature/universal_coercion
feature/cloneability
hotfix/expect_exception_change
bugfix/recursive_return_statement_check
bugfix/require_return
bugfix/return_type
feature/cleanup1
feature/clean_lexer_interface
research/gmalloc
feature/type_enforcer_cast_instr_emit
feature/meta_programming
feature/direct_func_call
bugfix/return_position
bugfix/is_same_type_fallback
feature/lexer_interface
feature/parser_interface
arrays
pointers
bugfix/function_parameter_type_parse
casting
compiler_object
extern_symbols
literal_encodings
uniform_stdalone_varass
remove_typequeue
linearizer_cleanup
parsetypedev_fix
modules
loops
conditionals
vdva_func_param_merge
function_parameters_fix
path_dependency
function_dep
compiler_levels
parser
constants
constants_float
develop
typecheck
deps_refactor
codegen
lexer
typecheck_refactor_varexp_makeacyclic
weighting
testing_thing
typecheck_refactor_varexp
typecheck_refactor
type_check_codegen_reducedparseclass_excep
typecheck_codegen
typecheck_codegen_educedparseclass
typecheck_reliancetree
static_support
codegen.sync-conflict-20210606-150925-O3W7KWN
develop.sync-conflict-20210606-150924-O3W7KWN
struct_support
typecheck.sync-conflict-20210606-150925-O3W7KWN
entity_declaration_type_checking
symbol_table
parser.sync-conflict-20210405-185821-O3W7KWN
parser_exception_before
develop_before_lexer_parser_merge_parseName
if_statement_parsing
exception_except
expression_parsing
master.sync-conflict-20210316-165421-O3W7KWN
expression_parsing.sync-conflict-20210316-090018-O3W7KWN
multimodule/changeset2
multimodule/changeset1
pointer_cast_merge
parsetypeddeclaration_onlytype_parsecast_new
pointers_coerce
v0.5.3
v0.5.2
v0.5.1
v0.5.0
v0.4.4
v0.4.3
v0.4.2
v0.4.1
v0.4.0
v0.3.0
v0.2.0
v0.1.0
v0.0.5
v0.0.4
v0.0.3
v0.0.2
v0.0.1
Labels
Clear labels   
dependency

Dependency tree generation

  
emit

Code emitting

  
hashmapper

Anything pertaining to the HashMapper symbol mapping code

  
lebanonmapper

Anything pertaining to the LebanonMapper symbol mapping code

  
lexer

Related to the tokenizer

  
meta

Meta processor related

  
needsfix

Urgent fix required

  
parser

Parser related

  
qol

Quality-of-life related

  
question

A question, not needed fix

  
resolution

Related to the resolver

  
typing

TypeChecker and Resolver related

No Label
dependency
emit
hashmapper
lebanonmapper
lexer
meta
needsfix
parser
qol
question
resolution
typing
Milestone
Clear milestone
No items
No Milestone
Clean ups
Projects
Clear projects
No project
Dependency tree, type-checking and codegen
Assignees
Clear assignees
No Assignees
deavmi
1 Participants
Notifications
Total Time Spent: 9 minutes 46 seconds
deavmi
9 minutes 46 seconds
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

2024-05-08

Dependencies

No dependencies set.

Reference: tlang/tlang#175
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?