🐞 Bugfix: expect(string) should throw ParserException atleast #147

New Issue

deavmi · 2023-07-16T18:48:06+01:00

deavmi commented

2023-07-16 18:48:06 +01:00

What is this?

The expect(SymbolType, Token) throws SyntaxError (which is a kind-of ParserException. However, expect(string) throws TError (actual type).

Change expect(string)'s behaviour
- Make it non-static
- We'll need versions of expect(string) for (as they relied on a static version of Parser's expect(string):
  - dependency generator
  - typechecker
Ensure unit tests are updated

## What is this? The `expect(SymbolType, Token)` throws `SyntaxError` (which is a kind-of `ParserException`. **However**, `expect(string)` throws `TError` (actual type). - [x] Change `expect(string)`'s behaviour - [x] Make it non-`static` - [x] We'll need versions of `expect(string)` for (as they relied on a `static` version of `Parser`'s `expect(string)`: - [x] dependency generator - [x] typechecker - [x] Ensure unit tests are updated

deavmi added reference vardec_varass_dependency

2023-07-16 18:48:09 +01:00

deavmi added this to the Parser project 2023-07-16 18:48:12 +01:00

deavmi added the

parser

label 2023-07-16 18:48:17 +01:00

deavmi added this to the Basics milestone 2023-07-16 18:48:19 +01:00

deavmi self-assigned this 2023-07-16 18:48:23 +01:00

deavmi changed reference from ~~vardec_varass_dependency~~ to hotfix/expect_exception_change

2023-07-16 19:16:44 +01:00

deavmi changed title from ~~expect(string) should throw ParserException atleast~~ to 🐞 Bugfix: expect(string) should throw ParserException atleast

2023-07-16 19:17:07 +01:00

deavmi added spent time 2023-07-16 19:20:01 +01:00

3 minutes

deavmi started working 2023-07-16 19:20:03 +01:00

deavmi added the due date 2023-07-18

2023-07-16 19:20:11 +01:00

deavmi commented

2023-07-16 19:32:31 +01:00

Looks good to me 👍 , going to merge...