🐞️ isSameType: Add a base case #114

Closed
opened 2023-04-21 14:08:08 +01:00 by deavmi · 5 comments
Owner

What is this?

I want to backport a change from #113 which actually made isSameType(Type t1, Type t2) more "finished" so to speak. It was missing a fallback case fo typeid(t1) == typeid(t2).

## What is this? I want to backport a change from #113 which actually made `isSameType(Type t1, Type t2)` more _"finished"_ so to speak. It was missing a fallback case fo `typeid(t1) == typeid(t2)`.
deavmi added the
typing
needsfix
labels 2023-04-21 14:11:24 +01:00
deavmi added this to the Basics milestone 2023-04-21 14:11:27 +01:00
deavmi added this to the Dependency tree, type-checking and codegen project 2023-04-21 14:11:30 +01:00
deavmi self-assigned this 2023-04-21 14:11:35 +01:00
deavmi added the due date 2023-04-21 2023-04-21 14:11:39 +01:00
deavmi added reference bugfix/is_same_type_fallback 2023-04-21 14:12:31 +01:00
deavmi started working 2023-04-21 14:12:40 +01:00
Author
Owner

Backported this in commit dd83b65393dbdc7bedde62d8a4eefb9100b87f22 to the branch this issue is assigned.

Backported this in commit `dd83b65393dbdc7bedde62d8a4eefb9100b87f22` to the branch this issue is assigned.
Author
Owner

Backported this in commit dd83b65393dbdc7bedde62d8a4eefb9100b87f22 to the branch this issue is assigned.

Unit tests pass, CI passes

> Backported this in commit `dd83b65393dbdc7bedde62d8a4eefb9100b87f22` to the branch this issue is assigned. Unit tests pass, CI passes ✅
deavmi stopped working 2023-04-21 14:16:39 +01:00
3 minutes 59 seconds
Author
Owner

I just need to merge this now.

I just need to merge this now.
Author
Owner

Merging...

Merging...
Author
Owner

Merged with CI

Merged with CI ✅
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Total Time Spent: 3 minutes 59 seconds
deavmi
3 minutes 59 seconds
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

2023-04-21

Reference: tlang/tlang#114
No description provided.