Casting improvement, parseTypedDeclaration() #110

New Issue

deavmi · 2023-04-14T11:55:13+01:00

deavmi commented

2023-04-14 11:55:13 +01:00

What is this?

To add support for parseType() which could hold the code that parseTypedDeclaration() uses when it parses the <type> <identifier> ['=' <assigment>] ';' (the <type> part).

Technically this will help us with:

parseCast() #87
Support for arrays in #81 (we can hoist a lot of that into this - possibly) - we might have to see - but worth looking at

## What is this? To add support for `parseType()` which could hold the code that `parseTypedDeclaration()` uses when it parses the `<type> <identifier> ['=' <assigment>] ';'` (the `<type>` part). Technically this will help us with: 1. `parseCast()` #87 2. Support for arrays in #81 (we can hoist a lot of that into this - possibly) - we might have to see - but worth looking at

deavmi added the

parser

label 2023-04-14 11:56:33 +01:00

deavmi added this to the Parser project 2023-04-14 11:56:35 +01:00

deavmi added this to the Basics milestone 2023-04-14 11:56:38 +01:00

deavmi self-assigned this 2023-04-14 11:56:41 +01:00

deavmi commented

2023-04-14 11:58:35 +01:00

Solution potentiale

We could rather keep parseTypedDeclaration(...) as is and add another default argument bool wantsAssignment (or RATHER re-use that maybe to mean assignment in the cases of non function?)

## Solution potentiale We _could_ rather keep `parseTypedDeclaration(...)` as is and add another default argument `bool wantsAssignment` (or RATHER re-use that maybe to mean assignment in the cases of non function?)

deavmi added reference vardec_varass_dependency

2023-04-14 11:58:49 +01:00

deavmi commented

2023-04-14 12:00:52 +01:00

Solution potentiale

We could rather keep parseTypedDeclaration(...) as is and add another default argument bool wantsAssignment (or RATHER re-use that maybe to mean assignment in the cases of non function?)

We do this already look...

/* Check for `=` (var dec) */
else if (symbolType == SymbolType.ASSIGN)
{
	// Only continue if variable declarations are allowed
    if(allowVarDec)
    {
    	// Only continue if assignments are allowed
        if(wantsBody)
        {
        	/* Consume the `=` token */
            nextToken();
            
            ...

> ## Solution potentiale > > We _could_ rather keep `parseTypedDeclaration(...)` as is and add another default argument `bool wantsAssignment` (or RATHER re-use that maybe to mean assignment in the cases of non function?) We do this already look... ```d /* Check for `=` (var dec) */ else if (symbolType == SymbolType.ASSIGN) { // Only continue if variable declarations are allowed if(allowVarDec) { // Only continue if assignments are allowed if(wantsBody) { /* Consume the `=` token */ nextToken(); ... ```

deavmi commented

2023-04-14 12:04:08 +01:00

Okay, next thing though - it returns a TypedEntity and DOES expect an identifier. We may need to add a new flag to say dontExpectIdentifier.

Okay, next thing though - it returns a `TypedEntity` and DOES expect an identifier. We may need to add a new flag to say `dontExpectIdentifier`.

deavmi commented

2023-04-14 12:04:40 +01:00

Solution potentiale 2 ✅

Okay, next thing though - it returns a TypedEntity and DOES expect an identifier. We may need to add a new flag to say dontExpectIdentifier.

Actually, just have a onlyType=true, then we stop there rather.
It returns a TypedEntity, so it needs a name? Perhaps we generate a bogus one with an empty identifier.
On return in the call made to parseTypedDeclaration(onlyType=true) by parseCast() we can then extract the typeString from the TypedEntity.

## Solution potentiale 2 ✅ > Okay, next thing though - it returns a `TypedEntity` and DOES expect an identifier. We may need to add a new flag to say `dontExpectIdentifier`. 1. Actually, just have a `onlyType=true`, then we stop there rather. 2. It returns a TypedEntity, so it needs a name? Perhaps we generate a bogus one with an empty identifier. 3. On return in the call made to `parseTypedDeclaration(onlyType=true)` by `parseCast()` we can then extract the _typeString_ from the `TypedEntity`.

deavmi changed reference from ~~vardec_varass_dependency~~ to casting

2023-04-14 12:32:37 +01:00

deavmi commented

2023-04-14 12:34:26 +01:00

Nous sommes en allent avec solution potentiale deux comme de commit 990b8a7d8721103d2181225ac5c6d40ee265a340 (tag: parsetypeddeclaration_onlytype_parsecast_new)

Nous sommes en allent avec solution potentiale deux comme de commit `990b8a7d8721103d2181225ac5c6d40ee265a340` (tag: `parsetypeddeclaration_onlytype_parsecast_new`)

deavmi added the

needsfix

label 2023-04-14 12:34:58 +01:00

deavmi added the due date 2023-04-14

2023-04-14 12:35:05 +01:00

deavmi changed title from ~~parseType()~~ to Casting improvement, parseTypedDeclaration()

2023-04-14 12:38:21 +01:00

deavmi commented

2023-04-14 12:38:36 +01:00

Merging this now to vardec_varass_dependency

Merging this now to `vardec_varass_dependency`

deavmi closed this issue