Uniformity: Make StandaloneVariableAssignment use a VariableAssignmentNode like VariableDeclaration does #100

New Issue

deavmi · 2023-02-03T14:31:51Z

deavmi commented

2023-02-03 14:31:51 +00:00

What is this?

Currently a variable declaration with an assignment is a Variable Declaration-> VariableAssignment -> ValueInstr, but Standalone Assignments currently are a StandaloneAssignment -> ValueInstr.

We should be doing StandaloneAssignment -> VariableAssignment -> ValueInstr, that or do away with the middle man.

### What is this? Currently a variable declaration with an assignment is a `Variable Declaration-> VariableAssignment -> ValueInstr`, but Standalone Assignments currently are a `StandaloneAssignment -> ValueInstr`. We _should_ be doing `StandaloneAssignment -> VariableAssignment -> ValueInstr`, that or do away with the middle man.

deavmi added the

typing

dependency

qol

labels 2023-02-03 14:32:08 +00:00

deavmi added this to the Dependency tree, type-checking and codegen project 2023-02-03 14:32:13 +00:00

deavmi self-assigned this 2023-02-03 14:32:17 +00:00

deavmi added the due date 2023-02-04

2023-02-03 14:32:28 +00:00

deavmi added a new dependency 2023-02-03 14:32:35 +00:00

#94 Literal encodings

deavmi started working 2023-02-03 14:32:56 +00:00

deavmi stopped working 2023-02-03 14:33:00 +00:00

4 seconds

deavmi added reference uniform_stdalone_varass

2023-02-03 14:33:51 +00:00

deavmi commented

2023-02-04 12:19:48 +00:00

I settled on the following now:

Variable Declaration (with assignment) ... -> Expression
VariableAssignentStdAlone -> Expression

Most uniform way and cuts the middle man out.

I settled on the following now: 1. `Variable Declaration` (with assignment) `... -> Expression` 2. `VariableAssignentStdAlone -> Expression` Most uniform way and cuts the middle man out.

deavmi closed this issue

2023-02-04 12:19:49 +00:00

Sign in to join this conversation.

No Label