- Fixed a possible bug whereby the `Receiver` and `Sender` may exit on start as they get to their `client.running` read before the main thread gets to setting `running = true`
- Removed unused import
- Added comment for future work
- Fixed typo
Receiver
- Added commented out code for future work
Sender
- Added commented out code for future work
- On call to `rq(byte[])` by the `Client` thread wake up the `Receiver` thread
- Added a TODO about the first call to `notifyAll()`
- Added a `wait()` call
- Removed `yield()` calls
Sender
- On call to `sq(byte[])` by the `Client` thread wake up the `Sender` thread
- Added a TODO about the first call to `notifyAll()`
- Added a `wait()` call
- Removed `yield()` calls
Client
- Ensure we wake up the `Receiver` and `Sender` threads such that they don't hang on their calls to `wait()`
- Added a TODO comment
- Moved `IRCEventType`, `IRCEvent` and `PongEvent` to a new module `events`
Client
- Removed old `recvQueue`, `sendQueue`, their respective locks and threads
- Removed any initializations of the aforementioned
- Added calls to start the `ReceiverThread` and `SenderThread` on call to `connect()`
- Updated `disconnect()`, `sendMessage(string)` and `receiveQ(ubyte[])` to use the new `ReceiverThread` and `SenderThread`
Receiver
- Added missing import
- Updated imports
- Moved `IRCEvent`, `IRCEventType` and `PongEvent` outside of the `Client` class
- Made `engine`, `running` and `socket` package-level accessible
Package
- Fixed package for `client`
Main package
- Updated public imports for the `birchwood` package
- Fixed conflicting symbol name `Event` arising from the use of `Eventy` and `libsnooze`
- Initialize the libsnooze event
- Initialize the queue mutex
- Set the thread's worker function
Sender
- Fixed conflicting symbol name `Event` arising from the use of `Eventy` and `libsnooze`
- Initialize the libsnooze event
- Initialize the queue mutex
- Set the thread's worker function
Protocol
- Moved module `message` to new package `protocol`
- Moved module `constants` to new package `protocol`
- Fixed bug with `directMessage(string, string[])` when more than one user in a multi-case was passed in
Unit tests
- Added two more unit tests relating to direct messages
- Namely testing out two scenarios for `directMessage(string, string[])`
- Added missing `dur` import
Sender
- Added missing `dur` import
Exceptions
- Moved exceptions to its own module
Core/Client
- Renamed to `client`
Package
- Updated import for `client` module
- Added import of `BirchwoodException`
- Added import of `ConnectionInfo`
Conninfo
- Moved `ConnectionInfo` to its own module
- Fixed bug whereby the leaving of multiple channels broke after the first channel in `leaveChannel(string[])`
Unit tests
- Test leaving multiple channels, a single channel (singular) and a single channel (multi)
- Test `directMessage(string, string)` (so singular) to send to myself
- Adding such a test will test the direct message receive handler which helps us a lot in increasing code coverage
- Fixed bug in `channelMessage(string, string[])` in the case where multiple channels were specified then the message would fail to send to the channels after the first one specified
Unit tests
- Disabled using `command(string, string, string)` to join a channel, rather use `joinChannel(string)`
- Added tests for singular `channelMessage(string, string[])` and multiple `channelMessage(string, string[])`
- Added imports
- Added a receive queue with a corresponding mutex
- Added a field to hold the associated `Client` object
Send
- Added imports
- Added a send queue with a corresponding mutex
- Added a field to hold the associated `Client` object
- Fixed bug within `channelMessage(string,string[])` which would leave the channel provided instead of sending the message provided to the the channel provided as it called `leaveChannel(channel[0])` instead of `channelMessage(string, string)`
- Added a field of type `Event` to hold a libsnooze object representing when a new message has been received and is to be processed
Sender
- Added a field of type `Event` to hold a libsnooze object representing when a new message is to be sent and is to be processed
- Disagnosed hot-loop causing high load average (and wasting run queue time with meaningless work)
- Offending functions are `sendHandlerFunc()` and `recvHandlerFunc()` and NOT eventy (as latest version doesn't do that
