1
0
mirror of https://github.com/deavmi/birchwood synced 2024-09-20 11:22:53 +02:00
- Removed TODOs from `sendMessage(Message)`
- Added TODOs to to `channelMessage(string, stringp[])`, `channelMessage(string, string)`, `directMessage(string, string[])` and `directMessage(string, string)`
This commit is contained in:
Tristan B. Velloza Kildaire 2023-07-03 18:05:29 +02:00
parent 9dc4a870dd
commit 5076169117

View File

@ -475,6 +475,8 @@ public class Client : Thread
*/ */
public void directMessage(string message, string[] recipients) public void directMessage(string message, string[] recipients)
{ {
// TODO: Chunked sends when over limit of `message`
/* Single recipient */ /* Single recipient */
if(recipients.length == 1) if(recipients.length == 1)
{ {
@ -550,6 +552,8 @@ public class Client : Thread
*/ */
public void directMessage(string message, string recipient) public void directMessage(string message, string recipient)
{ {
// TODO: Chunked sends when over limit of `message`
/* Ensure the message and recipient are valid text */ /* Ensure the message and recipient are valid text */
if(isValidText(message) && isValidText(recipient)) if(isValidText(message) && isValidText(recipient))
{ {
@ -582,6 +586,8 @@ public class Client : Thread
*/ */
public void channelMessage(string message, string[] channels) public void channelMessage(string message, string[] channels)
{ {
// TODO: Chunked sends when over limit of `message`
/* If single channel */ /* If single channel */
if(channels.length == 1) if(channels.length == 1)
{ {
@ -657,6 +663,8 @@ public class Client : Thread
*/ */
public void channelMessage(string message, string channel) public void channelMessage(string message, string channel)
{ {
// TODO: Chunked sends when over limit of `message`
//TODO: Add check on recipient //TODO: Add check on recipient
//TODO: Add emptiness check //TODO: Add emptiness check
if(isValidText(message) && isValidText(channel)) if(isValidText(message) && isValidText(channel))
@ -954,17 +962,9 @@ public class Client : Thread
*/ */
private void sendMessage(Message message) private void sendMessage(Message message)
{ {
// TODO: Do message splits here
/* Encode the message */ /* Encode the message */
ubyte[] encodedMessage = encodeMessage(message.encode()); ubyte[] encodedMessage = encodeMessage(message.encode());
// TODO: Decide on the chunks required
ulong chunksRequired = encodedMessage.length/512;
// FIXME: I mean should this maybe be something that channelMessage
// ... does as I don't feel nor think we can issue several messages in general
/* If the message is 512 bytes or less then send */ /* If the message is 512 bytes or less then send */
if(encodedMessage.length <= 512) if(encodedMessage.length <= 512)
{ {