tlang/tlang
tlang
/
tlang
mirror of https://github.com/tbklang/tlang.git
2
0
Fork 0
Code Issues 41 Projects 5 Releases Wiki Activity

🧹️🧼 Cleanup: Pool provider #161

New Issue
Closed
opened 2023-12-06 09:11:38 +00:00 by deavmi · 24 comments
deavmi commented 2023-12-06 09:11:38 +00:00
Owner
Copy Link

Purpose

The purpose of this is to have each DNodeGenerator not rely on the static DNode[Statement] nodePool anymore but to rather have us provide a Pool/PoolManager to each instance and they use that. This means we won't have to clear the static field anymore (which caused a bug in the past (if you wanted to do multiple compilation sessions)).

Todo

  • IPoolManager interface designed
  • PoolManager implementation
  • Usage within the dependency/core.d module
  • Remove old pooling system
    • Any traces of it in TypeChecker and Dependency
## Purpose The purpose of this is to have each `DNodeGenerator` not rely on the `static DNode[Statement] nodePool` anymore but to rather have us provide a `Pool`/`PoolManager` to each instance and they use that. This means we won't have to clear the static field anymore (which caused a bug in the past (if you wanted to do multiple compilation sessions)). ## Todo - [x] `IPoolManager` interface designed - [x] `PoolManager` implementation - [x] Usage within the `dependency/core.d` module - [x] Remove old pooling system * Any traces of it in `TypeChecker` and `Dependency`
deavmi added the
dependency
 label 2023-12-06 09:11:48 +00:00
deavmi self-assigned this 2023-12-06 09:11:52 +00:00
deavmi added reference vardec_varass_dependency 2023-12-06 09:11:56 +00:00
deavmi added this to the Dependency tree, type-checking and codegen project 2023-12-06 09:11:59 +00:00
deavmi added this to the Clean ups milestone 2023-12-06 09:12:03 +00:00
deavmi added the due date 2023-12-12 2023-12-06 09:12:17 +00:00
deavmi started working 2023-12-06 09:12:20 +00:00
deavmi changed reference from vardec_varass_dependency to feature/poolmngr 2023-12-06 09:14:18 +00:00
deavmi commented 2023-12-06 09:42:25 +00:00
Author
Owner
Copy Link

Added an implementation of the IPoolManager interface in the form of PoolManager ✅

Added an implementation of the `IPoolManager` interface in the form of `PoolManager` ✅
deavmi changed title from Clean up: Pool provider to 🧹️🧼 Cleanup: Pool provider 2023-12-06 09:43:25 +00:00
deavmi stopped working 2023-12-06 09:43:29 +00:00
31 minutes 9 seconds
deavmi started working 2023-12-06 11:13:50 +00:00
deavmi commented 2023-12-06 11:29:48 +00:00
Author
Owner
Copy Link

Added unittesting for the PoolManager and they pass ✅

Added unittesting for the `PoolManager` and they pass ✅
deavmi stopped working 2023-12-06 11:45:58 +00:00
32 minutes 8 seconds
deavmi added spent time 2023-12-06 13:10:45 +00:00
30 minutes
deavmi started working 2023-12-06 13:10:48 +00:00
deavmi commented 2023-12-06 13:11:47 +00:00
Author
Owner
Copy Link

Working on this now, as part of this I want to try and remove the DNodeGenerator itself from the DNode constructor

Working on this now, as part of this I want to try and remove the `DNodeGenerator` itself from the `DNode` constructor
deavmi stopped working 2023-12-06 14:51:06 +00:00
1 hour 40 minutes
deavmi added spent time 2023-12-06 14:58:40 +00:00
10 minutes
deavmi commented 2023-12-06 14:58:55 +00:00
Author
Owner
Copy Link

Will work on this throughout the week, done for now. Will do more tonight.

Will work on this throughout the week, done for now. Will do more tonight.
deavmi started working 2023-12-06 19:05:49 +00:00
deavmi stopped working 2023-12-06 19:05:56 +00:00
7 seconds
deavmi added spent time 2023-12-06 19:06:04 +00:00
10 minutes
deavmi started working 2023-12-06 19:06:09 +00:00
deavmi added a new dependency 2023-12-06 19:06:53 +00:00
#41 Dependency linearization clean up
deavmi added a new dependency 2023-12-06 19:08:42 +00:00
#157 ⚡ Feature: Multi-module support
deavmi stopped working 2023-12-06 19:08:47 +00:00
2 minutes 38 seconds
deavmi started working 2023-12-06 19:10:18 +00:00
deavmi commented 2023-12-06 19:29:26 +00:00
Author
Owner
Copy Link

Pushed updates constructors for the sub-types of DNode such as VariableNode, FuncDefNode and so forth... ✅

Pushed updates constructors for the sub-types of `DNode` such as `VariableNode`, `FuncDefNode` and so forth... ✅
deavmi stopped working 2023-12-06 19:29:36 +00:00
19 minutes 18 seconds
deavmi started working 2023-12-06 19:35:16 +00:00
deavmi commented 2023-12-06 19:37:17 +00:00
Author
Owner
Copy Link

Purpose

The purpose of this is to have each DNodeGenerator not rely on the static DNode[Statement] nodePool anymore but to rather have us provide a Pool/PoolManager to each instance and they use that. This means we won't have to clear the static field anymore (which caused a bug in the past (if you wanted to do multiple compilation sessions)).

Todo

  • IPoolManager interface designed
  • PoolManager implementation
  • Usage within the dependency/core.d module

Last bullet point is being worked on right now as we speak. basically done just need to make sure on somethings but all tests are locally passing ✅

> ## Purpose > > The purpose of this is to have each `DNodeGenerator` not rely on the `static DNode[Statement] nodePool` anymore but to rather have us provide a `Pool`/`PoolManager` to each instance and they use that. This means we won't have to clear the static field anymore (which caused a bug in the past (if you wanted to do multiple compilation sessions)). > > ## Todo > > - [x] `IPoolManager` interface designed > - [x] `PoolManager` implementation > - [ ] Usage within the `dependency/core.d` module Last bullet point is being worked on right now as we speak. basically done just need to make sure on somethings but all tests are **locally passing** ✅
deavmi stopped working 2023-12-06 19:37:22 +00:00
2 minutes 6 seconds
deavmi started working 2023-12-06 19:45:31 +00:00
deavmi commented 2023-12-06 20:00:40 +00:00
Author
Owner
Copy Link

Purpose

The purpose of this is to have each DNodeGenerator not rely on the static DNode[Statement] nodePool anymore but to rather have us provide a Pool/PoolManager to each instance and they use that. This means we won't have to clear the static field anymore (which caused a bug in the past (if you wanted to do multiple compilation sessions)).

Todo

  • IPoolManager interface designed
  • PoolManager implementation
  • Usage within the dependency/core.d module

Last bullet point is being worked on right now as we speak. basically done just need to make sure on somethings but all tests are locally passing ✅

Pushed the updated dependency/core.d ✅

> > ## Purpose > > > > The purpose of this is to have each `DNodeGenerator` not rely on the `static DNode[Statement] nodePool` anymore but to rather have us provide a `Pool`/`PoolManager` to each instance and they use that. This means we won't have to clear the static field anymore (which caused a bug in the past (if you wanted to do multiple compilation sessions)). > > > > ## Todo > > > > - [x] `IPoolManager` interface designed > > - [x] `PoolManager` implementation > > - [ ] Usage within the `dependency/core.d` module > > Last bullet point is being worked on right now as we speak. basically done just need to make sure on somethings but all tests are **locally passing** ✅ Pushed the updated `dependency/core.d` ✅
deavmi commented 2023-12-06 20:02:47 +00:00
Author
Owner
Copy Link

Purpose

The purpose of this is to have each DNodeGenerator not rely on the static DNode[Statement] nodePool anymore but to rather have us provide a Pool/PoolManager to each instance and they use that. This means we won't have to clear the static field anymore (which caused a bug in the past (if you wanted to do multiple compilation sessions)).

Todo

  • IPoolManager interface designed
  • PoolManager implementation
  • Usage within the dependency/core.d module

Last bullet point is being worked on right now as we speak. basically done just need to make sure on somethings but all tests are locally passing ✅

Pushed the updated TypeChecker ✅

> > ## Purpose > > > > The purpose of this is to have each `DNodeGenerator` not rely on the `static DNode[Statement] nodePool` anymore but to rather have us provide a `Pool`/`PoolManager` to each instance and they use that. This means we won't have to clear the static field anymore (which caused a bug in the past (if you wanted to do multiple compilation sessions)). > > > > ## Todo > > > > - [x] `IPoolManager` interface designed > > - [x] `PoolManager` implementation > > - [ ] Usage within the `dependency/core.d` module > > Last bullet point is being worked on right now as we speak. basically done just need to make sure on somethings but all tests are **locally passing** ✅ Pushed the updated `TypeChecker` ✅
deavmi commented 2023-12-06 20:03:03 +00:00
Author
Owner
Copy Link

All unittests pass ✅

All unittests pass ✅
deavmi commented 2023-12-06 20:06:07 +00:00
Author
Owner
Copy Link

CI/CD passes ✅

CI/CD passes ✅
deavmi stopped working 2023-12-06 20:06:12 +00:00
20 minutes 41 seconds
deavmi started working 2023-12-08 16:02:08 +00:00
deavmi commented 2023-12-08 16:02:21 +00:00
Author
Owner
Copy Link

Working now on removing any reference to the static node pool...

Working now on removing any reference to the static node pool...
deavmi commented 2023-12-08 16:08:40 +00:00
Author
Owner
Copy Link

Purpose

The purpose of this is to have each DNodeGenerator not rely on the static DNode[Statement] nodePool anymore but to rather have us provide a Pool/PoolManager to each instance and they use that. This means we won't have to clear the static field anymore (which caused a bug in the past (if you wanted to do multiple compilation sessions)).

Todo

  • IPoolManager interface designed
  • PoolManager implementation
  • Usage within the dependency/core.d module
  • Remove old pooling system
    • Any traces of it in TypeChecker and Dependency
  • Added a MdouleVariableDeclaration DNode generation method
  • Removed nodePool - some references still remain however
> ## Purpose > > The purpose of this is to have each `DNodeGenerator` not rely on the `static DNode[Statement] nodePool` anymore but to rather have us provide a `Pool`/`PoolManager` to each instance and they use that. This means we won't have to clear the static field anymore (which caused a bug in the past (if you wanted to do multiple compilation sessions)). > > ## Todo > > - [x] `IPoolManager` interface designed > - [x] `PoolManager` implementation > - [x] Usage within the `dependency/core.d` module > - [ ] Remove old pooling system > * Any traces of it in `TypeChecker` and `Dependency` - Added a `MdouleVariableDeclaration` DNode generation method - Removed `nodePool` - some references still remain however
deavmi stopped working 2023-12-08 16:09:52 +00:00
7 minutes 44 seconds
deavmi added spent time 2023-12-08 16:20:41 +00:00
5 minutes
deavmi started working 2023-12-08 16:20:42 +00:00
deavmi commented 2023-12-08 16:23:33 +00:00
Author
Owner
Copy Link

Purpose

The purpose of this is to have each DNodeGenerator not rely on the static DNode[Statement] nodePool anymore but to rather have us provide a Pool/PoolManager to each instance and they use that. This means we won't have to clear the static field anymore (which caused a bug in the past (if you wanted to do multiple compilation sessions)).

Todo

  • IPoolManager interface designed
  • PoolManager implementation
  • Usage within the dependency/core.d module
  • Remove old pooling system
    • Any traces of it in TypeChecker and Dependency
  • Added a MdouleVariableDeclaration DNode generation method
  • Removed nodePool - some references still remain however

Everything is now migrated over

> > ## Purpose > > > > The purpose of this is to have each `DNodeGenerator` not rely on the `static DNode[Statement] nodePool` anymore but to rather have us provide a `Pool`/`PoolManager` to each instance and they use that. This means we won't have to clear the static field anymore (which caused a bug in the past (if you wanted to do multiple compilation sessions)). > > > > ## Todo > > > > - [x] `IPoolManager` interface designed > > - [x] `PoolManager` implementation > > - [x] Usage within the `dependency/core.d` module > > - [ ] Remove old pooling system > > * Any traces of it in `TypeChecker` and `Dependency` > > - Added a `MdouleVariableDeclaration` DNode generation method > - Removed `nodePool` - some references still remain however Everything is now migrated over
deavmi commented 2023-12-08 16:25:26 +00:00
Author
Owner
Copy Link

Purpose

The purpose of this is to have each DNodeGenerator not rely on the static DNode[Statement] nodePool anymore but to rather have us provide a Pool/PoolManager to each instance and they use that. This means we won't have to clear the static field anymore (which caused a bug in the past (if you wanted to do multiple compilation sessions)).

Todo

  • IPoolManager interface designed
  • PoolManager implementation
  • Usage within the dependency/core.d module
  • Remove old pooling system
    • Any traces of it in TypeChecker and Dependency

There were no traces in the TypeChecker, that was rather the clearFuncDefs() we were thinking about - which is a seperate issue - see #162

> ## Purpose > > The purpose of this is to have each `DNodeGenerator` not rely on the `static DNode[Statement] nodePool` anymore but to rather have us provide a `Pool`/`PoolManager` to each instance and they use that. This means we won't have to clear the static field anymore (which caused a bug in the past (if you wanted to do multiple compilation sessions)). > > ## Todo > > - [x] `IPoolManager` interface designed > - [x] `PoolManager` implementation > - [x] Usage within the `dependency/core.d` module > - [ ] Remove old pooling system > * Any traces of it in `TypeChecker` and `Dependency` There were no traces in the `TypeChecker`, that was rather the `clearFuncDefs()` we were thinking about - which is a seperate issue - see #162
deavmi commented 2023-12-08 16:28:28 +00:00
Author
Owner
Copy Link

Unit tests pass ✅

Unit tests pass ✅
deavmi commented 2023-12-08 16:29:43 +00:00
Author
Owner
Copy Link

CI/CD passes ✅

CI/CD passes ✅
deavmi stopped working 2023-12-08 16:29:47 +00:00
9 minutes 5 seconds
deavmi started working 2023-12-10 10:20:39 +00:00
deavmi commented 2023-12-10 10:20:44 +00:00
Author
Owner
Copy Link

Documenting now...

Documenting now...
deavmi commented 2023-12-10 10:22:49 +00:00
Author
Owner
Copy Link

Documenting now...

Done ✅

> Documenting now... Done ✅
deavmi stopped working 2023-12-10 10:23:02 +00:00
2 minutes 23 seconds
deavmi removed the due date 2023-12-12 2023-12-29 17:49:46 +00:00
deavmi added the due date 2024-01-06 2023-12-29 17:49:56 +00:00
deavmi removed the due date 2024-01-06 2024-02-26 09:27:55 +00:00
deavmi added the due date 2024-03-31 2024-02-26 09:27:59 +00:00
deavmi commented 2024-02-26 21:18:54 +00:00
Author
Owner
Copy Link

We must merge this tomorrow.

We must merge this tomorrow.
deavmi started working 2024-02-27 08:14:04 +00:00
deavmi commented 2024-02-27 08:14:14 +00:00
Author
Owner
Copy Link

Need to upstream recent changes into this

Need to upstream recent changes into this
deavmi commented 2024-02-27 08:28:47 +00:00
Author
Owner
Copy Link

Need to upstream recent changes into this

Done and CI/CD passes ✅

> Need to upstream recent changes into this Done and CI/CD passes ✅
deavmi commented 2024-02-27 08:30:27 +00:00
Author
Owner
Copy Link

Looks good to me, merging...

Looks good to me, merging...
deavmi commented 2024-02-27 08:30:38 +00:00
Author
Owner
Copy Link

Merged

Merged
deavmi commented 2024-02-27 08:32:18 +00:00
Author
Owner
Copy Link

CI/CD ✅

Closing issue.

CI/CD ✅ Closing issue.
deavmi stopped working 2024-02-27 08:32:18 +00:00
18 minutes 14 seconds
Sign in to join this conversation.
feature/poolmngr
Branches Tags
Clear current reference
master
feature/aliases
vardec_varass_dependency
cleanup/depgen_root_removal
feature/modifiers
bugfix/dgen_expressionless_returns
cleanup/remove_dnodegeneratorbase
feature/comments
feature/operator_precedence
feature/reporting
bugfix/single_line_comment_bug
feature/logging_upgrade
feature/multi_module
feature/unused_vars_detection
feature/container_methods
feature/strat_resolve_collectors
feature/predicate_based_resolver
feature/poolmngr
hotfix/func_defs_in_dep_generator
feature/lexer_improvements
feature/structs
feature/behavec_preinline
bugfix/fix_multi_compile
feature/annotations
hotfix/simply_varexp_dnode_generation
hotfix/jcli_upgrade_fix
feature/class_static_init
feature/universal_coercion
feature/cloneability
hotfix/expect_exception_change
bugfix/recursive_return_statement_check
bugfix/require_return
bugfix/return_type
feature/cleanup1
feature/clean_lexer_interface
research/gmalloc
feature/type_enforcer_cast_instr_emit
feature/meta_programming
feature/direct_func_call
bugfix/return_position
bugfix/is_same_type_fallback
feature/lexer_interface
feature/parser_interface
arrays
pointers
bugfix/function_parameter_type_parse
casting
compiler_object
extern_symbols
literal_encodings
uniform_stdalone_varass
remove_typequeue
linearizer_cleanup
parsetypedev_fix
modules
loops
conditionals
vdva_func_param_merge
function_parameters_fix
path_dependency
function_dep
compiler_levels
parser
constants
constants_float
develop
typecheck
deps_refactor
codegen
lexer
typecheck_refactor_varexp_makeacyclic
weighting
testing_thing
typecheck_refactor_varexp
typecheck_refactor
type_check_codegen_reducedparseclass_excep
typecheck_codegen
typecheck_codegen_educedparseclass
typecheck_reliancetree
static_support
codegen.sync-conflict-20210606-150925-O3W7KWN
develop.sync-conflict-20210606-150924-O3W7KWN
struct_support
typecheck.sync-conflict-20210606-150925-O3W7KWN
entity_declaration_type_checking
symbol_table
parser.sync-conflict-20210405-185821-O3W7KWN
parser_exception_before
develop_before_lexer_parser_merge_parseName
if_statement_parsing
exception_except
expression_parsing
master.sync-conflict-20210316-165421-O3W7KWN
expression_parsing.sync-conflict-20210316-090018-O3W7KWN
Clear current reference
multimodule/changeset2
multimodule/changeset1
pointer_cast_merge
parsetypeddeclaration_onlytype_parsecast_new
pointers_coerce
v0.5.3
v0.5.2
v0.5.1
v0.5.0
v0.4.4
v0.4.3
v0.4.2
v0.4.1
v0.4.0
v0.3.0
v0.2.0
v0.1.0
v0.0.5
v0.0.4
v0.0.3
v0.0.2
v0.0.1
Labels
Clear labels   
dependency

Dependency tree generation

  
emit

Code emitting

  
hashmapper

Anything pertaining to the HashMapper symbol mapping code

  
lebanonmapper

Anything pertaining to the LebanonMapper symbol mapping code

  
lexer

Related to the tokenizer

  
meta

Meta processor related

  
needsfix

Urgent fix required

  
parser

Parser related

  
qol

Quality-of-life related

  
question

A question, not needed fix

  
resolution

Related to the resolver

  
typing

TypeChecker and Resolver related

No Label
dependency
emit
hashmapper
lebanonmapper
lexer
meta
needsfix
parser
qol
question
resolution
typing
Milestone
Clear milestone
No items
No Milestone
Clean ups
Projects
Clear projects
No project
Dependency tree, type-checking and codegen
Assignees
Clear assignees
No Assignees
deavmi
1 Participants
Notifications
Total Time Spent: 5 hours
deavmi
5 hours
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

2024-03-31

Blocks
#157 ⚡ Feature: Multi-module support
tlang/tlang
Reference: tlang/tlang#161
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?