Merge c886ba184b into b6106883da

- `opSlice()` now forwards to `opSlice(size_t, size_t)`

source/niknaks/containers.d

@@ -742,16 +742,7 @@ if(isSector!(SectorType)())
 
     public T[] opSlice()
     {
-        T[] buff;
-        foreach(SectorType sector; this.sectors)
-        {
-            buff ~= sector[];
-        }
-
-        // Trim to "fake" size
-        buff.length = this.curSize;
-
-        return buff;
+        return this[0..this.length];
     }
 
     public T[] opSlice(size_t start, size_t end)
@@ -1012,4 +1003,35 @@ unittest
     view ~= 5;
 
     assert(view[0..5] == [1,2,3,4,5]);
+
+    // test: start <= end invariant broken
+    try
+    {
+        auto j = view[1..0];
+        assert(false);
+    }
+    catch(RangeError e)
+    {
+
+    }
+
+    // test: end out of bounds
+    try
+    {
+        auto j = view[1..view.length+1];
+        assert(false);
+    }
+    catch(RangeError e)
+    {
+
+    }
+
+    int[] d = [1,2,3];
+    writeln("according to dlang: ", d[1..2]);
+
+    writeln("test lekker: ", view[1..2]);
+    assert(view[1..2] == [2]);
+
+    writeln("test lekker: ", view[1..1]);
+    assert(view[1..1] == []);
 }