deavmi/libsnooze
deavmi
/
libsnooze
mirror of https://github.com/deavmi/libsnooze
1
0
Fork 0
Code Issues 5 Packages Projects Releases Wiki Activity

🐞️ Bugfix: Interruptible wait #5

New Issue
Open
opened 2023-06-09 08:50:03 +01:00 by deavmi · 6 comments
deavmi commented 2023-06-09 08:50:03 +01:00
Owner
Copy Link

What is this?

I want to be able to handle the case where the select() system call inside of wait() returns with -1 indicating an error but is due to a signal that has been received (we can detect this via the errno() function).

  • Implement
  • Test
    • Test with signal
    • Update other tests to catch this
  • Document
## What is this? I want to be able to handle the case where the `select()` system call inside of `wait()` returns with `-1` indicating an error but is due to a signal that has been received (we can detect this via the `errno()` function). - [x] Implement - [ ] Test - [ ] Test with signal - [ ] Update other tests to catch this - [x] Document
deavmi self-assigned this 2023-06-09 08:50:27 +01:00
deavmi added the
bug
enhancement
 labels 2023-06-09 08:50:34 +01:00
deavmi added reference feature/interruptible 2023-06-09 08:50:36 +01:00
deavmi added the due date 2023-06-11 2023-06-09 08:50:45 +01:00
deavmi changed title from Interruptible wait to 🐞️ Bugfix: Interruptible wait 2023-06-09 08:51:14 +01:00
deavmi started working 2023-06-09 09:39:21 +01:00
deavmi commented 2023-06-09 11:23:58 +01:00
Author
Owner
Copy Link

Going to test this later, I will have to write some unit test that generates a signal to systematically test this.

Going to test this later, I will have to write some unit test that generates a signal to systematically test this.
deavmi stopped working 2023-06-09 11:24:01 +01:00
1 hour 44 minutes
deavmi started working 2023-06-10 13:38:29 +01:00
deavmi stopped working 2023-06-10 15:05:58 +01:00
1 hour 27 minutes
deavmi started working 2023-06-12 07:29:04 +01:00
deavmi commented 2023-06-12 07:29:29 +01:00
Author
Owner
Copy Link

Going to take this for a test in the birchwood IRC project and see how well it fares.

I did manually test it and it worked, I will write a unit test soon and see where else, if anywhere, I need to do this.

Going to take this for a test in the birchwood IRC project and see how well it fares. I did manually test it and it worked, I will write a unit test soon and see where else, if anywhere, I need to do this.
deavmi stopped working 2023-06-12 20:04:08 +01:00
12 hours 35 minutes
deavmi started working 2023-06-13 19:24:31 +01:00
deavmi stopped working 2023-06-13 19:24:34 +01:00
3 seconds
deavmi modified the due date from 2023-06-11 to 2023-06-30 2023-06-13 19:24:40 +01:00
deavmi started working 2023-06-13 19:24:43 +01:00
deavmi commented 2023-06-13 19:25:28 +01:00
Author
Owner
Copy Link

Todo

Honestly, almost done. Just working on cleaning it up - and I want to add testing for other things:

  • Timeout testing?
  • InterruptedException testing
    • We need to send a signal to the thread ID to interrupt it and test this automatically
## Todo Honestly, almost done. Just working on cleaning it up - and I want to add testing for other things: - [x] Timeout testing? - [ ] InterruptedException testing * We need to send a signal to the thread ID to interrupt it and test this automatically
deavmi stopped working 2023-06-13 19:25:36 +01:00
53 seconds
deavmi started working 2023-06-14 14:35:03 +01:00
deavmi commented 2023-06-14 14:35:27 +01:00
Author
Owner
Copy Link

It is implemented, awaiting unittest-based testing

It is implemented, awaiting unittest-based testing
deavmi stopped working 2023-06-14 14:35:37 +01:00
34 seconds
deavmi started working 2023-06-14 14:46:36 +01:00
deavmi commented 2023-06-14 14:47:15 +01:00
Author
Owner
Copy Link

Todo

Honestly, almost done. Just working on cleaning it up - and I want to add testing for other things:

  • Timeout testing?
  • InterruptedException testing
    • We need to send a signal to the thread ID to interrupt it and test this automatically

Timeout testing is already done ✅

> ## Todo > > Honestly, almost done. Just working on cleaning it up - and I want to add testing for other things: > > - [ ] Timeout testing? > - [ ] InterruptedException testing > * We need to send a signal to the thread ID to interrupt it and test this automatically > > Timeout testing is already done ✅
deavmi commented 2023-06-14 14:52:45 +01:00
Author
Owner
Copy Link

What is this?

I want to be able to handle the case where the select() system call inside of wait() returns with -1 indicating an error but is due to a signal that has been received (we can detect this via the errno() function).

  • Implement
  • Test
    • Test with signal
    • Update other tests to catch this
  • Document

Documentation is now done

> ## What is this? > > I want to be able to handle the case where the `select()` system call inside of `wait()` returns with `-1` indicating an error but is due to a signal that has been received (we can detect this via the `errno()` function). > > - [x] Implement > - [ ] Test > - [ ] Test with signal > - [ ] Update other tests to catch this > - [ ] Document Documentation is now done
deavmi stopped working 2023-06-14 14:54:09 +01:00
7 minutes 33 seconds
Sign in to join this conversation.
feature/interruptible
Branches Tags
Clear current reference
master
feature/disposable
feature/interruptible
feature/ensurable_parameter
bufix/unlock_on_error
gh-pages
Clear current reference
v1.3.0-beta
v1.2.3-beta
v1.2.2-beta
v1.2.1-beta
v1.2.0-beta
v1.1.0-beta
v1.0.20-beta
v1.0.19-beta
v1.0.18-beta
v1.0.17-beta
v1.0.16-beta
v1.0.15-beta
v1.0.14-beta
v1.0.13-beta
v1.0.12-beta
v1.0.11-beta
v1.0.10-beta
v1.0.9-beta
v1.0.8-beta
v1.0.7-beta
v1.0.6-beta
v1.0.5-beta
v1.0.4-beta
v1.0.3-beta
v1.0.2-beta
v1.0.1-beta
v1.0.0-beta
v0.3.7
v0.3.6
v0.3.5
v0.3.4
v0.3.3
v0.3.2
v0.3.1
v0.3.0
v0.2.9
v0.2.8
v0.2.7
v0.2.6
v0.2.5
v0.2.4
v0.2.3
v0.2.2
v0.2.1
v0.2.0
v0.1.0
v0.0.4
v0.0.3
v0.0.2
v0.0.1
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
deavmi
1 Participants
Notifications
Total Time Spent: 15 hours 56 minutes
deavmi
15 hours 56 minutes
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

2023-06-30

Dependencies

No dependencies set.

Reference: deavmi/libsnooze#5
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?