From ce5418a9bdc24dc35d9c8d11fd0b8a781dd34ae4 Mon Sep 17 00:00:00 2001 From: "Tristan B. Velloza Kildaire" Date: Mon, 25 Sep 2023 17:11:00 +0200 Subject: [PATCH 1/3] CoapClient - Added a TODO --- source/doap/client/client.d | 2 ++ 1 file changed, 2 insertions(+) diff --git a/source/doap/client/client.d b/source/doap/client/client.d index 41b80de..b85ffee 100644 --- a/source/doap/client/client.d +++ b/source/doap/client/client.d @@ -199,6 +199,8 @@ public class CoapClient if(request.getToken() == token) { foundRequest = request; + + // FIXME: We should remove it here? break; } } From 95673cf21f87ad44f79af506cb98e88e742190e9 Mon Sep 17 00:00:00 2001 From: "Tristan B. Velloza Kildaire" Date: Mon, 25 Sep 2023 17:15:40 +0200 Subject: [PATCH 2/3] CoapClient - `yankRequest(ubyte[] token)` now will also remove the matched `CoapRequest` from the `outgoingRequests` queue - Fixes #6 --- source/doap/client/client.d | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/source/doap/client/client.d b/source/doap/client/client.d index b85ffee..b0e125a 100644 --- a/source/doap/client/client.d +++ b/source/doap/client/client.d @@ -181,7 +181,9 @@ public class CoapClient /** * Given a token this will try and find an active - * request with a matching token and return it + * request with a matching token and return it. + * + * This will also remove it from the requests queue. * * Params: * token = the token @@ -200,7 +202,8 @@ public class CoapClient { foundRequest = request; - // FIXME: We should remove it here? + outgoingRequests.linearRemoveElement(foundRequest); + break; } } From 3b7be4073f23c01b3844296c0241532aa3b8a658 Mon Sep 17 00:00:00 2001 From: "Tristan B. Velloza Kildaire" Date: Mon, 25 Sep 2023 17:22:52 +0200 Subject: [PATCH 3/3] CoapClient - Cleaned up --- source/doap/client/client.d | 2 -- 1 file changed, 2 deletions(-) diff --git a/source/doap/client/client.d b/source/doap/client/client.d index b0e125a..9659980 100644 --- a/source/doap/client/client.d +++ b/source/doap/client/client.d @@ -201,9 +201,7 @@ public class CoapClient if(request.getToken() == token) { foundRequest = request; - outgoingRequests.linearRemoveElement(foundRequest); - break; } }